Feature: encode_colour() and _native() allow na_value#38
Open
zeehio wants to merge 14 commits intothomasp85:mainfrom
Open
Feature: encode_colour() and _native() allow na_value#38zeehio wants to merge 14 commits intothomasp85:mainfrom
zeehio wants to merge 14 commits intothomasp85:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built on top of #37 and #36 (please review those first), this pull request allows for
encode_colour()to pass ana_value.Besides being a convenience feature, it also enables me to reduce passes or creating copies of larger vectors.
I am aiming to improve performance in how scale mapping works in ggplot2 with larger vectors. Related to tidyverse/ggplot2#4989